Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of historical leaf temp/par averaging approach. #111

Merged
merged 8 commits into from
Mar 19, 2024

Conversation

drnimbusrain
Copy link
Member

@drnimbusrain drnimbusrain commented Feb 8, 2024

@MaggieMarvin This is a first crack at explicitly calculating historical leaf temp and par values used in canopy-app. I have created a new option, "hist_opt" to turn this on (hist_opt=1). See the description in the README, but if the canopy-app simulation is < 24 hours then instantaneous values will still be used, and if turned on and run > 24 hours, historical running avearges can be used. Can you closely test this using a longer simulation and analyzing the output after 24 hours against MEGAN and PECORINO?

This is currently a draft and needs thorough testing:

  • Compare spatial impacts of historical averaging against MEGANv2 and MEGANv3
  • Test historical approach for > 24 hours for assessing the e-folding running averages
  • Test historical + gamma_sm impacts.

@drnimbusrain drnimbusrain marked this pull request as draft February 8, 2024 03:06
@drnimbusrain drnimbusrain linked an issue Feb 8, 2024 that may be closed by this pull request
@drnimbusrain drnimbusrain added enhancement New feature or request help wanted Extra attention is needed labels Feb 14, 2024
@drnimbusrain drnimbusrain marked this pull request as ready for review February 27, 2024 18:38
@drnimbusrain
Copy link
Member Author

drnimbusrain commented Feb 28, 2024

@MaggieMarvin I have merged develop (with gamma_sm changes) into historical for your testing of both options on and running it longer to test the running average feature when > 24 hours.

Copy link
Collaborator

@MaggieMarvin MaggieMarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The moving 24-hour average behaves as expected, for example different length simulation windows produce equivalent results for the same time and no historical effects are applied before 25 hours. For our test case of 08/01/2021 1800 UTC, turning on historical effects has a significant impact, reducing emissions across the region by about 40% on average (see attached plot), and improving agreement with MEGANv3 approaching a factor of 2.
map_canopyapp_bio_NA-36

@drnimbusrain drnimbusrain merged commit 072f619 into develop Mar 19, 2024
4 checks passed
@drnimbusrain drnimbusrain deleted the historical branch March 19, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Biogenics] Use of Historical Leaf Temperatures and PAR
2 participants