improve description of hermaphroditism #258
Conversation
iantaylor-NOAA
added
documentation
|
Here are the artifacts from your PR: |
|
Here are the artifacts from your PR: |
|
Here are the artifacts from your PR: |
|
@iantaylor-NOAA please see my comment in the issue and my additional commits. I'm going to convert this from a draft to ready for review. |
|
Here are the artifacts from your PR: |
|
Here are the artifacts from your PR: |
|
Here are the artifacts from your PR: |
|
Here are the artifacts from your PR: |
|
Here are the artifacts from your PR: |
|
@e-perl-NOAA, thanks for your work on this.
This resolves issue #259. |
|
Here are the artifacts from your PR: |
|
Thank you all, this is much clearer now. Appreciate the super quick response to this issue! |
9control.tex
Outdated
| @@ -677,28 +677,28 @@ | |||
| & & 0 = not used; \\ | |||
| & & 1 = invoke female to male age-specific function; and \\ | |||
| & & -1 = invoke male to female age-specific function. \\ | |||
| & & Note: this creates the annual, age-specific fraction that change sex, it is not the fraction that is each sex. \Bstrut\\ | |||
| & & Note: this creates the annual, age-specific fraction that change sex, it is not the fraction that is each sex. Also, the fraction female parameter should be configured to reflect the fraction of age 0 fish. Values of 0 or 1 may lead to NaN likelihoods, so we recommend changing values that would be fixed at 0 or 1 to 0.000001 or 0.999999.\Bstrut\\ | |||
There was a problem hiding this comment.
@iantaylor-NOAA Is this the right place to put this? It looks like this section should be fixed at 0, 1, or -1 to turn on the option and the note makes it a bit confusing.
There was a problem hiding this comment.
Is this function that is being turned on related to he Fraction Female section?
There was a problem hiding this comment.
@e-perl-NOAA You're right. I wanted that information as close to the top of the hermaphroditism section as possible, but it would just get lost in that note. Instead, I've created a new intro section in 21ef32a prior to the table of control file settings which hopefully provides better overall information on the options and moved all the notes into that paragraph.
|
Here are the artifacts from your PR: |
|
Here are the artifacts from your PR: |
9control.tex
Outdated
| @@ -677,28 +677,28 @@ | |||
| & & 0 = not used; \\ | |||
| & & 1 = invoke female to male age-specific function; and \\ | |||
| & & -1 = invoke male to female age-specific function. \\ | |||
| & & Note: this creates the annual, age-specific fraction that change sex, it is not the fraction that is each sex. \Bstrut\\ | |||
| & & Note: this creates the annual, age-specific fraction that change sex, it is not the fraction that is each sex. Also, the fraction female parameter should be configured to reflect the fraction of age 0 fish. Values of 0 or 1 may lead to NaN likelihoods, so we recommend changing values that would be fixed at 0 or 1 to 0.000001 or 0.999999.\Bstrut\\ | |||
There was a problem hiding this comment.
Is this function that is being turned on related to he Fraction Female section?
|
@iantaylor-NOAA Thanks so much for your work on this! |
|
Here are the artifacts from your PR: |
|
Here are the artifacts from your PR: |
Here's a draft pull request inspired by this recent conversation https://groups.google.com/g/ss3-forum/c/S-Krkkn9qao.
If an equation is necessary, we can likely do something similar to the description of the parameter trends which also use cumulative normal functions:
https://github.com/nmfs-ost/ss3-doc/blob/main/tv_parameter_description.tex#L81.
See issue #259