Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermaphrodism parameter clarification #259

Closed
e-perl-NOAA opened this issue Oct 28, 2024 · 2 comments
Closed

Hermaphrodism parameter clarification #259

e-perl-NOAA opened this issue Oct 28, 2024 · 2 comments
Assignees

Comments

@e-perl-NOAA
Copy link
Collaborator

e-perl-NOAA commented Oct 28, 2024

Several changes suggested based on this ss3-forum post:

  1. Change:

\item A parameter line for inflection point (in age) at when fish may begin to change sex.

to

The inflection point where the transition rate is halfway from 0 to the asymptote.
  1. Change:

\item The asymptote of the maximum proportion that will transition to the other sex

to

The asymptote (the maximum proportion that will transition to the other sex in a time step)
  1. Add the following to the manual (@iantaylor-NOAA where were you thinking it would be good to add the following to the manual?):
The FracFemale parameter can't be either 0 or 1, so we recommend changing values that would be 0 or 1 to 0.000001 or 0.999999.
  1. Hyperlink hermaphrodism portion of control file to the "Ready Biology Parameters" hermaphrodism portion in the control file.
@marcnadon
Copy link

Change #1 I think is clear. Maybe "The inflection point where the transition rate is halfway from 0 to its asymptote."

Change #2, maybe: The asymptotic transition rate (the highest proportion that will transition to the other sex in a time step).

Change # 3: I haven't had this issue, it might be model-dependent, but probably a good idea to add this to the manual, I agree.

I would also add the information that the function is a cumulative normal, with parameter 2 (the standard deviation) is the SD of that normal distribution.

Thanks for help! Greatly appreciated.

@iantaylor-NOAA
Copy link
Contributor

Thanks for the feedback @marcnadon. Those changes will be reflected in the User Manual associated with the next release of SS3.
@e-perl-NOAA, thanks for posting the issue. I can make some minor edits on top of our ongoing Pull Request to reflect these latest comments and then mark as ready for you to take a look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants