-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add json_output #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs at least a test, but other than that and my comments, this looks good to me :)
Regarding the whole Format, docbook, etc discussion. I think nixdoc should have a json Output as Default. |
e49bb1d
to
8a96a00
Compare
8a96a00
to
1edc802
Compare
1edc802
to
267c357
Compare
I added a test, and took the opertunity to refactor a bunch of tests, e.g. making the test_main function actually test the main function instead of just some copied code.
I think that this should not happen here, but (if at all) in a new major relase since it breaks current behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the default matters at all really, because I don't expect anybody to use this tool directly, it's all through automation. So definitely not blocking imo, this PR looks good as-is to me, thanks!
This is useful if you have some other tool which makes use of the documentation data, e.g. a function search.