-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve Gemfile to support groups #3
base: master
Are you sure you want to change the base?
Conversation
Now with 100% less magic! 😄 I don't see where you're ever using |
Oh, never mind -- wasn't paying close enough attention: |
@children = dependencies.map{|d| self.class.new(d, specs, groups) } | ||
end | ||
|
||
def run(seen = [], result = {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seen
should probably be a Set
.
o.on '--gemset=gemset.nix', 'path to the gemset.nix' do |value| | ||
options[:gemset] = File.expand_path(value) | ||
end | ||
ENV.delete('SSL_CERT_FILE') if ENV['SSL_CERT_FILE'] == '/no-cert-file.crt' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this mean that bundix would be inside of a sandbox anyways ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using it like nix-shell -p bundler --command ~/github/manveru/bundix/bin/bundix
, and having no SSL connections means bundix can't work. If you know a more elegant solution, please inform me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. No better solution to offer I'm afraid.
No description provided.