Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve Gemfile to support groups #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

resolve Gemfile to support groups #3

wants to merge 5 commits into from

Conversation

manveru
Copy link
Collaborator

@manveru manveru commented Apr 17, 2016

No description provided.

@cstrahan
Copy link

Now with 100% less magic! 😄

I don't see where you're ever using OPTIONS[:groups]...

@cstrahan
Copy link

Oh, never mind -- wasn't paying close enough attention: GemfileDependencyTree.run(options)

@children = dependencies.map{|d| self.class.new(d, specs, groups) }
end

def run(seen = [], result = {})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seen should probably be a Set.

o.on '--gemset=gemset.nix', 'path to the gemset.nix' do |value|
options[:gemset] = File.expand_path(value)
end
ENV.delete('SSL_CERT_FILE') if ENV['SSL_CERT_FILE'] == '/no-cert-file.crt'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that bundix would be inside of a sandbox anyways ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using it like nix-shell -p bundler --command ~/github/manveru/bundix/bin/bundix, and having no SSL connections means bundix can't work. If you know a more elegant solution, please inform me :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. No better solution to offer I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants