-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for platform windows #112
base: master
Are you sure you want to change the base?
Add support for platform windows #112
Conversation
@@ -68,6 +68,7 @@ def groups(spec, dep_cache) | |||
"mingw" => [{engine: "mingw"}], | |||
"truffleruby" => [{engine: "ruby"}], | |||
"x64_mingw" => [{engine: "mingw"}], | |||
"windows" => [{engine: "mswin"}, {engine: "mswin64"}, {engine: "mingw"}], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't 100% sure what engines
to list here, but basically took the list from Gem::Platform::WINDOWS
as defined here
@inscapist would we be able to get this merged into your fork? |
For context it looks like “windows” was added as an alias for existing windows platforms in bundler: rubygems/rubygems#5650 I encountered the issue as new Rails app Gemfiles use this alias instead of the mingX platforms it did before. |
@manveru Any chance you could take a look at this? If a gem like irb gets updated now, this results in an unclear error I tried these changes in a repository where I ran into this issue and they generated the expected gemset. |
Fixes #57
Several gems declare platform support for
windows
, including several dependencies of a newly-generatedrails
app