Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for platform windows #112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cjlarose
Copy link

@cjlarose cjlarose commented Feb 8, 2024

Fixes #57

Several gems declare platform support for windows, including several dependencies of a newly-generated rails app

  • debug (1.9.1)
  • io-console (0.7.2)
  • irb (1.11.1)
  • psych (5.1.2)
  • rdoc (6.6.2)
  • reline (0.4.2)
  • stringio (3.1.0)

@@ -68,6 +68,7 @@ def groups(spec, dep_cache)
"mingw" => [{engine: "mingw"}],
"truffleruby" => [{engine: "ruby"}],
"x64_mingw" => [{engine: "mingw"}],
"windows" => [{engine: "mswin"}, {engine: "mswin64"}, {engine: "mingw"}],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't 100% sure what engines to list here, but basically took the list from Gem::Platform::WINDOWS as defined here

https://github.com/rubygems/rubygems/blob/8c98dbf1b1f6005b4e0343999d7fd556428fa0c2/bundler/lib/bundler/rubygems_ext.rb#L208

@jonknapp
Copy link

jonknapp commented Apr 6, 2024

@inscapist would we be able to get this merged into your fork?

@jonknapp
Copy link

jonknapp commented Apr 9, 2024

For context it looks like “windows” was added as an alias for existing windows platforms in bundler: rubygems/rubygems#5650

I encountered the issue as new Rails app Gemfiles use this alias instead of the mingX platforms it did before.

@inscapist
Copy link

@jonknapp thanks for providing the context, a PR has been merged into my fork!

@robbevp
Copy link

robbevp commented Aug 2, 2024

@manveru Any chance you could take a look at this? If a gem like irb gets updated now, this results in an unclear error /nix/store/np0gx2m7xkxrvx3ack88bv1zlpkcrgw9-bundix-2.5.2/lib/ruby/gems/3.1.0/gems/bundix-2.5.0/lib/bundix/nixer.rb:100:in serialize': Cannot convert to nix: nil`

I tried these changes in a repository where I ran into this issue and they generated the expected gemset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization of Nil object crashes the CLI
4 participants