Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change colorset for elevation graph to steelblue default theme #271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

edoput
Copy link

@edoput edoput commented Feb 14, 2017

Change color theme for leaflet elevation graph to steelblue, a default provided theme that look like this

screen shot 2017-02-13 at 20 44 13

the result provides better contrast for the elevation graph and the icons
screen shot 2017-02-14 at 11 20 22

The screenshots are taken from ninux.nodeshot.org by changing the class from lime-theme to steelblue-theme.

I couldn't see the map in the development installation of nodeshot but I could see that the theme was indeed changed

Close #270.

@nemesifier
Copy link
Member

nemesifier commented Feb 14, 2017

I don't think this is a real improvement, the color of the elevation profile is very similar to the sea, the initial issue was related to the close button, not the color of the elevation profile.

@edoput
Copy link
Author

edoput commented Feb 14, 2017

The problem I am trying to solve is a to have a pleasant graph with the good mix of color scheme and accessibility. The default steelblue theme is nicer than lime theme for the purpose.

Right now there are two problems with making the close button bigger, of a different color or with a colored background.

  • icon-close is reused everywhere; we can't have a background color without having it everywhere (in the legend, in the modal signup,...)
  • a tags inside the map are blue

some solutions

  • change from a to button (or something clickable), implement the css for .leaflet-container button
  • make the map tools a toggle button on the right toolbar, clicking it
  • change the color theme to a custom one, keep the close icon as a a tag (so we keep it blue), make the graph

The first solution requires changing some html, some js and css; the second is maybe better in term of UX as all the other tools are already toggles but requires a lot of work; the third solution is fairly simpler in term of changing a css file completely, swapping it with a custom one.

Given all this I would like to experiment with a custom color theme and maybe this option can fit nicely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants