Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance contrast in elevation leaflet close button #270

Open
edoput opened this issue Feb 8, 2017 · 8 comments
Open

Enhance contrast in elevation leaflet close button #270

edoput opened this issue Feb 8, 2017 · 8 comments

Comments

@edoput
Copy link

edoput commented Feb 8, 2017

screen shot 2017-02-08 at 15 54 18

The choosen color doesn't pop out of the elevation map and make the button hard to find

@edoput
Copy link
Author

edoput commented Feb 8, 2017

The incriminating line is this

@nemesifier
Copy link
Member

Could you send a patch?

@edoput
Copy link
Author

edoput commented Feb 8, 2017

Yes, I'll post some screenshots for review

@edoput
Copy link
Author

edoput commented Feb 8, 2017

185922
screen shot 2017-02-08 at 15 54 18
screen shot 2017-02-08 at 19 30 03

I'm thinking it won't be enough so maybe make it a little bigger or bolder

Here size is 1.5em and it's looking better, size comparable to a node

screen shot 2017-02-08 at 20 06 09

@nemesifier
Copy link
Member

Yea the last one is better.

Have you thought about a dark background for the button, with slightly rounded corners and light foreground?

@edoput
Copy link
Author

edoput commented Feb 9, 2017

That would be too similar to a node

Enhancing the size and a white, semitransparent background seem to do the trick, blue and green don't mix well in contrast

screen shot 2017-02-09 at 10 46 22

screen shot 2017-02-09 at 10 50 11

@edoput
Copy link
Author

edoput commented Feb 9, 2017

I need a pointer to where to find the leaflet.elevation.css not inlined, that would be hard to work with.

@nemesifier
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants