Extend api/semaphores to consume external semaphores. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android specific fixes to external sharing tests.
…to external_sharing
test_vulkan uses external semaphores imported from vulkan. api/semaphore test relies on semaphores created within OpenCL. The scenarios in api/semaphore are common for all semaphores irrespective of how they are created. Extend api/semaphore to consume external semaphores created outside of api/semaphore tests e.g. semaphores imported from vulkan. This allows test_vulkan to exercise semaphore cases covered by api/semaphores on semaphores created in Vulkan and imported in OpenCL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_vulkan uses external semaphores imported from vulkan.
api/semaphore test relies on semaphores created within OpenCL.
The scenarios in api/semaphore are common for all semaphores
irrespective of how they are created.
Extend api/semaphore to consume external semaphores created
outside of api/semaphore tests e.g. semaphores imported from vulkan.
This allows test_vulkan to exercise semaphore cases covered
by api/semaphores on semaphores created in Vulkan and imported
in OpenCL.