Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where setTimeout lingered on abort and a nested state machine was running #57

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Fix bug where setTimeout lingered on abort and a nested state machine was running #57

merged 7 commits into from
Aug 29, 2023

Commits on Aug 28, 2023

  1. Pass top-level abort signal to children states

    @nibble-4bits
    nibble-4bits committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    bcd52bd View commit details
    Browse the repository at this point in the history

  2. Pass root abort signal to sleep function

    @nibble-4bits
    nibble-4bits committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7014190 View commit details
    Browse the repository at this point in the history

  3. Pass root abort signal to Parallel, Map and Wait state handlers 

    This fixes the issue where the execution is not aborted when a `Parallel` or `Map` state that contain a `Wait` state is being executed, and `abort` is called
    @nibble-4bits
    nibble-4bits committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9183f97 View commit details
    Browse the repository at this point in the history

  4. Remove event listeners in sleep once promise is resolved

    @nibble-4bits
    nibble-4bits committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f2bb5d9 View commit details
    Browse the repository at this point in the history

  5. Add test case for sleep function being aborted using `rootAbortCont… 

    …roller` argument
    @nibble-4bits
    nibble-4bits committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    3d10896 View commit details
    Browse the repository at this point in the history

  6. Add test to ensure abort is propagated to nested state machines in … 

    …`Parallel` and `Map` states
    @nibble-4bits
    nibble-4bits committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a10b090 View commit details
    Browse the repository at this point in the history

  7. Simplify passing of rootAbortSignal

    @nibble-4bits
    nibble-4bits committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f82e74e View commit details
    Browse the repository at this point in the history