Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM publishing #44

Merged
merged 5 commits into from
Apr 18, 2024
Merged

NPM publishing #44

merged 5 commits into from
Apr 18, 2024

Conversation

mikemonteith
Copy link
Collaborator

@mikemonteith mikemonteith commented Apr 18, 2024 •
edited
Loading

NPM releases from github actions.

To release, we should just have to:

  1. Bump the package.json version number
  2. Add a changelog.md entry
  3. Create a release in github

@mikemonteith
NPM release pipeline
9c6ff78
@mikemonteith
Improve npm package bundle
0325b43 
- Name our scss entrypoint all.scss, to keep in line with other gov/nhs frontends
- Compile all source code into dist/nhsapp, not just nunjucks files
- Add nhsuk-frontend as a regular dependency, not a devDependency
@mikemonteith
Tag current version as an alpha release
d9f08f5
@mikemonteith
Start a changelog
ea82a20
@mikemonteith
First version should be 0.1.0, not 0.0.1
a460366
@mikemonteith mikemonteith changed the title WIP NPM publishing Apr 18, 2024
@davidhunter08 davidhunter08 merged commit 98aef67 into main Apr 18, 2024
1 check passed
@davidhunter08 davidhunter08 deleted the npm-publishing branch April 18, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhunter08 davidhunter08 davidhunter08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemonteith @davidhunter08