fix(github): release url (#268)

ngVenezuela · Aug 10, 2020 · 36d2312 · 36d2312
1 parent 8a92ab3
commit 36d2312
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/api/_utils/blog/feed.ts b/api/_utils/blog/feed.ts
@@ -15,7 +15,7 @@ interface BlogFeed {
  * TODO: for the ngVenezuela blog to work we have to wait until this is
  * closed: https://github.com/thepracticaldev/dev.to/issues/3363
  */
-const handleBlogFeed = async (feeds: BlogFeed[]) => {
+const handleBlogFeed = async (feeds: BlogFeed[]): Promise<void> => {
   if (MAIN_GROUP_ID) {
     const promises: Promise<void>[] = [];
 

diff --git a/api/_utils/github/feed.ts b/api/_utils/github/feed.ts
@@ -12,9 +12,10 @@ interface RepoConfig {
 const handleGithubFeed = async (
   repoConfig: RepoConfig,
   tags: string[],
-) => {
+): Promise<void> => {
   if (MAIN_GROUP_ID) {
     const promises: Promise<void>[] = [];
+    const repoMainUrl = repoConfig.feed.replace('releases.atom', '');
 
     tags.forEach(tag => {
       const promise = sendMessage({
@@ -25,7 +26,7 @@ const handleGithubFeed = async (
           .replace(
             '#{url}',
             repoConfig.hasChangelog
-              ? `https://github.com/${repoConfig.name}/blob/master/CHANGELOG.md`
+              ? `${repoMainUrl}blob/master/CHANGELOG.md`
               : `https://github.com/${repoConfig.name}/releases/tag/${tag}`,
           ),
       });