Skip to content

Commit

Permalink
test: increase timeouts for flaky tests (#15)
Browse files Browse the repository at this point in the history
This increases timeouts for the 2 flaky tests.

This also fixes a timeout issue for the "escapes quotes" test on Windows, since
we only invoked the done() callback from the unix code branch (a bug in #11).

Fixes #14
  • Loading branch information
nfischer authored Mar 17, 2018
1 parent 51a4b93 commit b809b82
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ describe('proxy', () => {
fs.existsSync(fa).should.equal(true);
fs.existsSync(fb).should.equal(true);
done();
});
}).timeout(5000);

it('avoids globs', (done) => {
const fa = 'a.txt';
Expand All @@ -268,7 +268,7 @@ describe('proxy', () => {
// These files are still ok
fs.existsSync(fa).should.equal(true);
done();
});
}).timeout(5000);

it('escapes quotes', (done) => {
if (unix()) {
Expand All @@ -277,12 +277,12 @@ describe('proxy', () => {
fs.existsSync(fquote).should.equal(true);
shell[delVarName](fquote);
fs.existsSync(fquote).should.equal(false);
done();
} else {
// Windows doesn't support `"` as a character in a filename, see
// https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx
console.log('skipping test');
}
done();
});
});
});

0 comments on commit b809b82

Please sign in to comment.