Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MIFARE Classic: replace writeBlock data type check #163

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: MIFARE Classic: replace writeBlock data type check #163

merged 1 commit into from
May 22, 2024

Conversation

knthm
Copy link
Contributor

@knthm knthm commented May 21, 2024 •
edited
Loading

Fix the writeBlock data input type check.

Types themselves cannot be tested with the is operator, only object instances.

Fixes #162

@Harry-Chen Harry-Chen merged commit b0d3d48 into nfcim:master May 22, 2024
2 checks passed
@Harry-Chen
Copy link
Contributor

Thanks! Yet another of my stupid mistake

@knthm knthm deleted the fix-mifare-classic-write branch May 22, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: MIFARE Classic: writeBlock calls fail due to invalid type check
2 participants
@knthm @Harry-Chen