-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sarek bcftools normalization #1682
base: dev
Are you sure you want to change the base?
Conversation
…cfs_with_tbis and fasta.
…cfs_with_tbis and fasta.
resolve issue with spacing Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
Hi all, I've modified the normalization step to include all VCFs, not just the germline ones. For this, I used the pull request from JC-Delmas as a base. I am aware that this still requires a lot of work, and I would greatly appreciate any advice or feedback you can provide. Thank you! Patricie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run nf-core modules update bcftools/norm
that's an old version of the modules
|
@nf-core-bot fix linting pretty please 🙏 |
We're missing CHANGELOG + tests + subway map |
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
@nf-core-bot fix linting pretty please 🙏 |
nextflow
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to commit this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is still there
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
Co-authored-by: Friederike Hanssen <friederike.hanssen@seqera.io>
Co-authored-by: Friederike Hanssen <friederike.hanssen@seqera.io>
…o sarek_bcftools_norm
issues we still need to assess: WHY do we output vcfs_tbi from the concatenate subworkflow, when we just need vcf for vcftools and we don't seem to remove them anywhere? We need a variant caller id from concatenate as well. I'm guessing we might need to output |
versions = versions.mix(TABIX_VCFS_NORM_SORT.out.versions) | ||
|
||
emit: | ||
vcfs = VCFS_NORM_SORT.out.vcf // normalized vcfs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that one should do the trick, but we need to figure out what to do with the tbis, and what's happening with the tbis on the concatenate side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, when I run tests for concatenate_vcfs and normalize_vcfs separately, they complete without any errors. The resulted ouputs are vcf.gz as well as vcf.gz.tbi (variant_calling/normalized/testN/testN.norm.vcf.gz, testN.norm.vcf.gz.tbi, testN.vcf.gz and variant_calling/concat/testN/testN.germline.vcf.gz, testN.germline.vcf.gz.tbi, ),. In case of normalized, there is an extra vcf.gz file (testN.vcf.gz) in the outdir, which I don't know where it comes from and if it causes any issues.
But in case I run test for both concatenate and normalize, the test fails with following warnings and errors - I think, the same we've encountered during the monday's meeting with Maxime.
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).