Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage.md #206

Merged
merged 19 commits into from
Dec 1, 2023
Merged

Update usage.md #206

merged 19 commits into from
Dec 1, 2023

Conversation

erikrikarddaniel
Copy link
Member

@erikrikarddaniel erikrikarddaniel commented Oct 25, 2023

I worked through the documentation until the section with example commands.

It's not consistent and there are likely a lot of problems, so let's see this as work in progress. Just add changes to this PR before we decide on merging.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/metatdenovo branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

I worked through the documentation until the section with example commands.

It's not consistent and there are likely a lot of problems, so let's see this as work in progress. Just add changes to this PR before we decide on merging.
@github-actions
Copy link

github-actions bot commented Oct 25, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a430885

+| ✅ 156 tests passed       |+
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.5.1
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • system_exit - System.exit in NfcoreSchema.groovy: System.exit(1) [line 180]

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-29 11:51:11

@erikrikarddaniel
Copy link
Member Author

@nf-core-bot fix linting

@erikrikarddaniel
Copy link
Member Author

@nf-core-bot fix linting

nf-core-bot and others added 9 commits November 28, 2023 15:29
Just some cosmetics/consistency things.
`Trim` for `Trim Galore!` not trimm, sorry missed it in last commit.
Some cosmetic fixes.
Some small fixes, probably missed a bunch.
This shouldn't be there, right?
Copy link
Collaborator

@danilodileo danilodileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danilodileo danilodileo merged commit 32c2945 into dev Dec 1, 2023
7 checks passed
@danilodileo danilodileo deleted the documentation branch December 5, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants