Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small issues #194

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Fix small issues #194

merged 4 commits into from
Oct 17, 2023

Conversation

danilodileo
Copy link
Collaborator

@danilodileo danilodileo commented Oct 17, 2023 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/metatdenovo branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This PR covers issue #170 and #163

@github-actions
Copy link

github-actions bot commented Oct 17, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 19f74da

+| ✅ 156 tests passed       |+
!| ❗   8 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.5.1
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in output.md: Write this documentation describing your workflow's output
  • system_exit - System.exit in NfcoreSchema.groovy: System.exit(1) [line 180]
  • schema_description - Ungrouped param in schema: dbname

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-17 11:08:49

emnilsson
emnilsson approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@emnilsson emnilsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise LGTM.

nextflow.config Show resolved Hide resolved
@danilodileo danilodileo merged commit 90887dc into nf-core:dev Oct 17, 2023
7 checks passed
@danilodileo danilodileo deleted the fix-small-issues branch October 18, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emnilsson emnilsson emnilsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danilodileo @emnilsson