config: Support falsy numeric and boolean values… #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
nextstrain-s-trs-falsy--bybzul
… tests To be fixed in the next commit. There's other config behaviours it would likely be useful to test, but this is a small start.
…instead of considering them missing. The values considered missing are now more clear: 1. undefined (i.e. not present) 2. null (i.e. present but explicitly null) 3. "" (i.e. present but empty, particularly for env vars) This allows falsy values¹ like the number 0 and boolean false to be configurable values², as expected to be for OIDC_IAT_BACKDATED_BY and REDIS_REQUIRED. For example, setting REDIS_REQUIRED=false is now functional as intended by "Allow and document how to run safely in production mode without Redis" (64f7d92). And setting OIDC_IAT_BACKDATED_BY=0 in the environment now overrides any value from the config file instead of being ignored. Related-to: <#739> ¹ <https://developer.mozilla.org/en-US/docs/Glossary/Falsy> ² Other falsy values like NaN and 0n are also now considered non-missing, but there's no way to express those in our current config sources, which permit only strings or JSON values. We may find ourselves wanting to treat NaN as missing too if config sources change.
tsibley
force-pushed
the
trs/falsy-config-vars
branch
from
edf621e
to
3fccf53
Compare
jameshadfield
approved these changes
Nov 2, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…instead of considering them missing.
The values considered missing are now more clear:
This allows falsy values¹ like the number 0 and boolean false to be
configurable values², as expected to be for OIDC_IAT_BACKDATED_BY and
REDIS_REQUIRED.
For example, setting REDIS_REQUIRED=false is now functional as intended
by "Allow and document how to run safely in production mode without
Redis" (64f7d92). And setting OIDC_IAT_BACKDATED_BY=0 in the
environment now overrides any value from the config file instead of
being ignored.
Related-to: #739
¹ https://developer.mozilla.org/en-US/docs/Glossary/Falsy
² Other falsy values like NaN and 0n are also now considered
non-missing, but there's no way to express those in our current config
sources, which permit only strings or JSON values. We may find
ourselves wanting to treat NaN as missing too if config sources
change.
Checklist