Merge display name and tile lists #1035
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
nextstrain-s-victorlin--moehjk
victorlin
force-pushed
the
victorlin/core-pathogen-list
branch
from
8486e6f
to
7240906
Compare
2 tasks
victorlin
force-pushed
the
victorlin/core-pathogen-list
branch
from
7240906
to
f9a6171
Compare
genehack
approved these changes
Oct 3, 2024
victorlin
force-pushed
the
victorlin/core-pathogen-list
branch
from
f9a6171
to
5c46de7
Compare
genehack
approved these changes
Oct 3, 2024
victorlin
force-pushed
the
victorlin/repurpose-showcase
branch
from
29bf64b
to
7bda4ea
Compare
This update simplifies the YAML file by removing redundant implementation details and should make content updates more straightforward. The `coreGroupDisplayNames` and `coreTiles` lists had overlapping information and are now combined into a single list of pathogens. Separate lists for display names and tiles are still used in the code, derived from the merged list. The key change is the tighter coupling between the display names shown in the card titles and the names shown in the tiles.
victorlin
force-pushed
the
victorlin/core-pathogen-list
branch
from
5c46de7
to
33aa9f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
Description of proposed changes
This update simplifies the YAML file by removing redundant implementation details and should make content updates more straightforward. The
coreGroupDisplayNamesandcoreTileslists had overlapping information and are now combined into a single list of pathogens.Separate lists for display names and tiles are still used in the code, derived from the merged list.
The key change is the tighter coupling between the display names shown in the card titles and the names shown in the tiles.
Related issue(s)
N/A
Checklist
pathogen.name, notpathogen.id