Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SymfonyBundle [closes #378] #490

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add SymfonyBundle [closes #378] #490

wants to merge 1 commit into from

Conversation

JanTvrdik
Copy link
Member

@JanTvrdik JanTvrdik commented Feb 12, 2021 •
edited
Loading

  • not well tested
  • supports only phpdoc repository loader
  • does not support repository dependency provider
  • findRepositories is copy-paste from NetteDI

@JanTvrdik JanTvrdik requested a review from hrach February 12, 2021 22:41
@JanTvrdik
Copy link
Member Author

It is possible to get rid of marking repositories as public by passing ServiceLocatorArgument to RepositoryLoader instead of ContainerInterface but I didn't figure out how to implement IRepositoryLoader::isCreated because ServiceProviderInterface does not have any method for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrach hrach Awaiting requested review from hrach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JanTvrdik