simple plan impl #69
Open
simple plan impl #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok so this above is my proposition. Any better implementation would require a pretty much complete rewrite of the core. |
JanTvrdik
force-pushed
the
master
branch
3 times, most recently
from
d0ab005
to
36fd4b7
Compare
JanTvrdik
force-pushed
the
master
branch
3 times, most recently
from
281a660
to
88684df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61
Intentionally very simple implementation. More complex would require many changes to the core, such as splitting
OrderResolver. This was started at https://github.com/Mikulas/migrations/tree/pr/exec-plan.This proposed solution is almost backwards compatible, with single exception of extending existing
IConfigurationwithgetPlanFilemethod. However, the method is allowed to returnNULL, in which case migrations completely skip all Plan code.Plan entries are created only with
migrations:createsymfony command. The Plan is checked for validity wheneverEngine\Runner::runis invoked.IMO this solves the merge/rebase problem this was initially intended for, with minimal changes to the codebase.