Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(attachments): add support for creating new attachments #6676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pbirrer
Copy link

@pbirrer pbirrer commented Nov 21, 2024

These changes enable users to create and insert new attachment files directly from within the editor.

📝 Summary

  • Introduced a new endpoint (Attachment#createAttachment) to create attachment files via POST requests.
  • Added createAttachment method in AttachmentService to handle file creation logic with permission checks.
  • Updated MediaHandler.vue and MediaHandler.provider.js to integrate the new attachment creation functionality in the editor.
  • Enhanced ActionAttachmentUpload.vue to support dynamic attachment creation from file app templates.
  • Extended SessionApi.js with a createAttachment method to interface with the new API endpoint.

🖼️ Screenshots

text-create-attachment

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

- Introduced a new endpoint (`Attachment#createAttachment`) to create attachment files via POST requests.
- Added `createAttachment` method in `AttachmentService` to handle file creation logic with permission checks.
- Updated `MediaHandler.vue` and `MediaHandler.provider.js` to integrate the new attachment creation functionality in the editor.
- Enhanced `ActionAttachmentUpload.vue` to support dynamic attachment creation from predefined templates.
- Included a new "Plus" icon for attachment creation actions in `icons.js`.
- Extended `SessionApi.js` with a `createAttachment` method to interface with the new API endpoint.
- Minor refactor and UI enhancements to support seamless attachment creation in the text editor.

These changes enable users to create and insert new attachment files directly from the editor, improving workflow efficiency.

Signed-off-by: Peter Birrer <peter.birrer@optonic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants