feat: allow editing completion date

[creightonfrance]

• [Feature Request] Editable completed dates #1184

This PR will allow changing the task completion date.

• If user tries to set completion date in the future, they will see error dialog.
• If user deletes completion date, the task will marked as not completed.

[raimund-schluessler]

Seems to work fine. But I am not sure we should show this date so prominently. I would rather move it down into the details section. Probably below the status drop-down. What do you think?

[creightonfrance]

That makes sense, it might be better under the status input since that determines this field's visibility. Making that change now 👍🏻

[creightonfrance]

Changes

I moved the field down to the details section. I also added a flag for the overdue check.

Question

Could you help me out with local lint checks? I run make and npm run lint, and I get hundreds of errors (mainly issues finding dependencies). I've fully opened up permissions locally for all files via chmod 777 * -R. Am I missing a step?

[raimund-schluessler]

Question

Could you help me out with local lint checks? I run make and npm run lint, and I get hundreds of errors (mainly issues finding dependencies). I've fully opened up permissions locally for all files via chmod 777 * -R. Am I missing a step?

Unfortunately, I see the same locally. And I couldn't figure out yet, why that happens. Probably worth opening an issue.

[raimund-schluessler]

@jancborchardt Could you please invite @creightonfrance to the Nextcloud repo?

[creightonfrance]

Question

Could you help me out with local lint checks? I run make and npm run lint, and I get hundreds of errors (mainly issues finding dependencies). I've fully opened up permissions locally for all files via chmod 777 * -R. Am I missing a step?

Unfortunately, I see the same locally. And I couldn't figure out yet, why that happens. Probably worth opening an issue.

I figured it out: issue only happens when the tasks repo is under the nextcloud/server repo (in apps, extra-apps, etc.). You have to run make in the base directory for nextcloud server, then make for this repo and lint should work fine 👍🏻 no code needed

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)