Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excluded_directories as config option #26651

Closed
thopico opened this issue Apr 20, 2021 · 10 comments
Closed

Add excluded_directories as config option #26651

thopico opened this issue Apr 20, 2021 · 10 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement Nice to have

Comments

@thopico
Copy link

thopico commented Apr 20, 2021

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
An Owncloud instance I administrate has lots of directories with tons of irrelevant files (eg temporary files or symlinks) on local and external storages. For now, we can use the excluded_directories option to tell OC to completely ignore the directories matching some patterns and to not include them in DB.

We would love to migrate our users to Nextcloud, but we can't find such option available. Nothing in the doc, and #6888 mention the app files_excludedirs which doesn't seem to live anymore. I believe there is a few more people hoping for this feature as well.

Describe the solution you'd like
Would be great if this option was also available on NC, either natively or through a custom app.

Describe alternatives you've considered
Haven't found any alternative.

Additional context
If someone has enough time to develop this feature, a bonus would be to accept wildcards in patterns.

Thank you

@thopico thopico added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Apr 20, 2021
@szaimen
Copy link
Contributor

szaimen commented Jul 2, 2021

Hi 👋

We are currently cleaning up our issue tracker. The feature described in this issues sounds like a good idea for a dedicated app. Feel free to post it in our "App ideas" section in the forum, to find a developer that wants to work on it:
https://help.nextcloud.com/c/apps/app-ideas/21

We are closing this issue here now, so the "issue tracker" of the server repository can be used better to track issues instead.

Cheers

@thopico
Copy link
Author

thopico commented Jul 6, 2021

I moved the feature request to help.nextcloud.com as requested : https://help.nextcloud.com/t/add-excluded-directories-as-config-option/119671

@rightsaidfred99
Copy link

Would be great to have.

Having a hard time where clients are downloading directories with @eadir folders everywhere from the NAS

@GuyPaddock
Copy link

Please give this unsigned release a spin; should work on 23x.:
https://github.com/Inveniem/nextcloud-files-excludedirs/releases/tag/v1.0.0-beta

I've provided updated docs in my fork of the Readme (specifically, how it works with existing vs. newly-added files):
https://github.com/Inveniem/nextcloud-files-excludedirs/blob/master/README.md

Feedback is welcome here:
https://github.com/Inveniem/nextcloud-files-excludedirs/issues

I'll have to look into publishing an official, signed package because I wasn't the original author of this one -- I just updated the work of others.

@wonx
Copy link

wonx commented Sep 11, 2022

I tried it on my 24.0.2 Nextcloud. It lets me activate the app, but I don't think it's actually paying attention to my exclusion rules.

I have a folder that I want to exclude in /user/files/Warehouse/Library/ (a Calibre library, containing thousands of folders that really slows down the scan). So I ran the following:
occ config:app:set files_excludedirs exclude --value ["Warehouse/Library"]

and then I rescan the library using: occ files:scan user --verbose
However I still see that folders within Warehouse/Library are still being scanned to the database.

Am I doing something wrong? Is it just that it is still not compatible with Nextcloud 24?
Also, is there a way to check what are the current excluded dirs?

@wonx
Copy link

wonx commented Sep 12, 2022

Yes. But I assumed that was to remove the existing files from the database. For now, I just wanted to test if adding an exclusion, the scan process would ignore that particular folder (which apparently didn´t). Is it because I'm using Nextcloud 24 and the excludedirs app is only compatible with nextcloud 23 and lower?

@GuyPaddock
Copy link

@wonx Hmm, I haven't yet tested with 24 so I am not sure. I know that on 23 it took effect for my next scan and matching files did not get added. Can you file an issue on my fork and let me know what your exclusion patterns look like and provide an example of an absolute path that's not matching?

@wonx
Copy link

wonx commented Sep 13, 2022

@GuyPaddock I can't seem to create an issue, it redirects me to Pull requests instead. Maybe you have to enable that option in your repository?

@GuyPaddock
Copy link

@wonx Sorry about that; just added it. Also, I've discovered a show-stopper issue on login that I need to address (Inveniem/nextcloud-files-excludedirs#1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement Nice to have
Projects
None yet
Development

No branches or pull requests

5 participants