-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't Seem to Work on Nextcloud 23 on Local Storage / Nextcloud 24 on External Storage #2
Comments
My previous test that I mentioned in nextcloud/server#26651 (comment) was also applied to an external storage and didn't work, the folders were scanned to the database. |
@wonx Thanks for filing this! I'll do more testing on NC v24. We are also using it almost exclusively with external storage and it's working for us in v23, so I'll have to see if I can identify what's different. |
@wonx The work item for this finally came up in my sprint queue so I could take another look at this. I can confirm that this does not appear to work in NC 24 even with local storage. I am looking to see what changed between 23 and 24 here. |
I'm able to reproduce this issue on local storage in NC 23, even though it was working for me with SMB-mounted external storage in NC 23 previously. |
This seems to be more reliable than previous ways to filter paths.
@janusn @wonx Can you try this new release? https://github.com/Inveniem/nextcloud-files-excludedirs/releases/tag/v1.0.1-beta Again, this will only affect new files not files that NC already knows about, so just bear that in mind. |
I did a quick test and seems to ignore the specified folder, so, so far so good! I'll write back if I find any issues. |
@GuyPaddock Thanks in advance. |
@janusn I would recommend disabling it through the |
Sorry for the late reply. My NAS was a bit funky and it took me quite a while to get it back to work. I can say the v.1.0.1 beta does not crash my NextCloud setup. I can log on it without an error. I cannot confirm the functionality yet as I am still cleaning up the filecache table. It takes much longer than I expect. I will report back once I have completed. Thanks for your effort. |
From my part, it seems to be working just fine. The complete directory scan, which used to take around 45-50 minutes, lowered to less than 20 minutes after excluded a folder with tens of thousands of subfolders, so I couldn't be happier. |
Sorry for the long waiting. I have reinstalled every thing related nextcloud including swag, redis, mariadb, duckdns... I am happy to report that after 3 days of running, the app seems to work well. Thank you. ... for example:
and settings of An external storage to |
@janusn Wonderful! Can you open a separate issue for your question? I'm actually not 100% sure of the answer since I did not write the original globbing support; I just fixed it up for this version. But if we have a separate issue for it someone else may be able to chime in before I find out :) |
@GuyPaddock I have created #3 as requested. Furthermore, I filed another bug #4 as well. Thanks a ton for this wonderful app! |
On new folders, @eadir pops up 100% of the time. |
Synopsis:
Folders from external storage acquired with local method is not excluded. I am not sure whether the non-external folders since I use it mainly on external storage.
Procedures performed:
# sudo -u abc -s /bin/bash -c "php7 /config/www/nextcloud/occ config:app:set files_excludedirs exclude --value '[\"@eaDir\",\"#snapshot\",\".*\"]'"
Config value exclude for app files_excludedirs set to ["@eaDir","#snapshot",".*"]
DELETE FROM oc_filecache WHERE oc_filecache.path = '@eaDir';
DELETE FROM oc_filecache WHERE oc_filecache.path = '#snapshot';
DELETE FROM oc_filecache WHERE oc_filecache.path LIKE '._%';
Expected result:
No folder with the name "@eadir" or "#snapshot" shows up.
Actual result:
Folders with the name "@eadir" or "#snapshot" are still visible.
Environment:
The text was updated successfully, but these errors were encountered: