Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: #248 Refresh from server when in view mode #450

Merged
merged 10 commits into from
Dec 31, 2019

Conversation

stefan-niedermann
Copy link
Member

@stefan-niedermann stefan-niedermann commented Aug 24, 2018

This PR basically works but whenever i set the new Content, it gets display but not rendered.

@korelstar any idea what might cause this behaviour?

Additionally: Currently this synchronizes all notes. Performance could be improved greatly if we only synchronize the current note.

@korelstar
Copy link
Member

This PR basically works but whenever i set the new Content, it gets display but not rendered.

@korelstar any idea what might cause this behaviour?

This may be related to the problem in #427:

After toggling a checkbox the content is displayed as plain text and does not get processed anymore

I have no idea how to fix this. Maybe you should report this to upstream (Rxmarkdown).

PS. I will try to do the requested reviews in the next days, but I can't promise ...

@stefan-niedermann
Copy link
Member Author

yydcdut/RxMarkdown#55

# Conflicts:
#	app/src/main/java/it/niedermann/owncloud/notes/android/fragment/NotePreviewFragment.java
@stefan-niedermann stefan-niedermann changed the title #248 Refresh from server when in view mode WIP: #248 Refresh from server when in view mode Feb 8, 2019
# Conflicts:
#	app/src/main/java/it/niedermann/owncloud/notes/android/fragment/NotePreviewFragment.java
#	app/src/main/res/layout/activity_single_note.xml
@stefan-niedermann
Copy link
Member Author

Some updates here: It seems that if one does not use JavaRx but the normal implementation, that the rendering after setting new content works correctly.

@stefan-niedermann
Copy link
Member Author

Aah, and yes. Toggling checkboxes seems to be possible with the normal implementation, too. It is currently active on this branch and i am happy if someone could help testing it.

@hanzei @rainerzufall @Offerel @jpggithub

@stefan-niedermann stefan-niedermann merged commit da67505 into master Dec 31, 2019
@stefan-niedermann stefan-niedermann deleted the refresh-preview branch December 31, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants