Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActionRadio): change modelValue to behave like NcCheckboxRadioSwitch #6264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(NcActionRadio): change modelValue to behave like NcCheckboxRadioSwitch #6264

wants to merge 1 commit into from

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • v-model: Boolean is quite unusable for radio-buttons, as it should store selected value (one from many options)
  • Should be changed by developers when migrate from checked to v-model, apart from that works as before

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • check if it's a breaking change
    • this.model = this.$refs.radio.checked is kept for backward compatibility

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
fix(NcActionRadio): change modelValue to behave like NcCheckboxRadioS…
0385abf 
…witch

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components labels Nov 25, 2024
@Antreesy Antreesy added this to the 8.21.1 milestone Nov 25, 2024
@Antreesy Antreesy requested a review from ShGKme November 25, 2024 11:09
@Antreesy Antreesy self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme Awaiting requested review from ShGKme

At least 2 approving reviews are required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Milestone
8.21.1
Development

Successfully merging this pull request may close these issues.
1 participant
@Antreesy