Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added design document for DERP relay integration #1840

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Added design document for DERP relay integration #1840

merged 1 commit into from
Jan 29, 2024

Conversation

vishnoianil
Copy link
Contributor

Fixes #1835

@netlify Netlify
Copy link

netlify bot commented Jan 19, 2024 •
edited
Loading

✅ Deploy Preview for nexodus-docs ready!

Name Link
🔨 Latest commit 7eaa624
🔍 Latest deploy log https://app.netlify.com/sites/nexodus-docs/deploys/65aa23fc65d25700090bb9d2
😎 Deploy Preview https://deploy-preview-1840--nexodus-docs.netlify.app/development/design/derp-relay
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mergify mergify bot added missing-docs-label missing has-docs or no-docs-needed missing-design-label missing has-design or no-design-needed label missing-tests-label This PR is missing a tests label, has-tests or no-tests-required labels Jan 19, 2024
@vishnoianil vishnoianil force-pushed the derp-design-doc branch 2 times, most recently from b626555 to 1930c74 Compare January 19, 2024 07:24
@vishnoianil vishnoianil added has-design This PR has a design document, either previously merged or included has-docs This PR has user-facing docs included no-tests-required PR does not require new test coverage and removed missing-docs-label missing has-docs or no-docs-needed missing-design-label missing has-design or no-design-needed label missing-tests-label This PR is missing a tests label, has-tests or no-tests-required labels Jan 19, 2024
@vishnoianil
Added design document for DERP relay integration
7eaa624 
Signed-off-by: Anil Kumar Vishnoi <avishnoi@redhat.com>
@vishnoianil vishnoianil requested review from russellb and removed request for russellb January 29, 2024 15:40
russellb
russellb approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing up your explanation! Any further questions or additions can be handled by future issues and PRs.

@mergify mergify bot merged commit 1a111ed into nexodus-io:main Jan 29, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
[deploy] Update qa images to 1a111ed:
d41415d 
Merge pull request #1840 from vishnoianil/derp-design-doc

Added design document for DERP relay integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellb russellb russellb approved these changes

Assignees
No one assigned
Labels
has-design This PR has a design document, either previously merged or included has-docs This PR has user-facing docs included no-tests-required PR does not require new test coverage
Projects
Nexodus Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write DERP integration design doc
2 participants
@vishnoianil @russellb