aws-sdk-lambda: don't use external segments #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the use of external request segments can cause confusion for Lambda entity relationships. should we wish to expose the underlying net call to the AWS back-end API in future, we can do so by simply removing the `disable_all_tracing` wrapper and allow the underlying Net::HTTP call to be instrumented.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
have the chain and prepend module files relatively include the main instrumentation file
tannalynn
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the use of external request segments can cause confusion for Lambda entity relationships. should we wish to expose the underlying net call to the AWS back-end API in future, we can do so by simply removing the
disable_all_tracingwrapper and allow the underlying Net::HTTP call to be instrumented.