aws-sdk-lambda fix #2939
Merged
aws-sdk-lambda fix #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 0a1527d sought to improve error handling, but incorrectly misused an `ensure` block to attempt to always return the raw client response. this faulty logic has been fixed. internal agent response handling errors are logged as desired, not re-raised to the user's app, and the user's app is guaranteed to always get the raw original response.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
hannahramadan
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 0a1527d sought to improve error handling, but incorrectly misused an
ensureblock to attempt to always return the raw client response.this faulty logic has been fixed. internal agent response handling errors are logged as desired, not re-raised to the user's app, and the user's app is guaranteed to always get the raw original response.