Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rdkafka runs in its own multiverse group #2908

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

tannalynn
Copy link
Contributor

@tannalynn tannalynn commented Oct 11, 2024

So this will make rdkafka run in it's own group for now. I named the group just kafka because i'd like to later include both kafka gems in it, but for now, for debugging our weird problems, I want it to only be rdkafka.

I also added the exit code to another string. We do already output the exit code in a different spot, but I wasn't seeing that message actually show up when we see our problem for some reason, so I've added it to a message that I do actually see, so maybe we'll get a little more info out of that.

Before:
"rdkafka" for Envfile entry 0 failed! 
Now
"rdkafka" for Envfile entry 0 failed! (exit: pid 9066 exit 1)

@tannalynn tannalynn marked this pull request as ready for review October 11, 2024 19:17
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.78% 93%
Branch 69.65% 50%

@tannalynn tannalynn merged commit 63eb706 into dev Oct 14, 2024
35 checks passed
@tannalynn tannalynn deleted the trying_stuff_for_rdkafka_failures branch November 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants