Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test coverage for Sidekiq job perform_inline #2836

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

fallwith
Copy link
Contributor

As discussed in #2195, add unit test coverage to demonstrate the agent's ability to instrument Sidekiq jobs when perform_inline is used.

add a test that confirms that `perform_inline` produces a segment
restrict the perform_inline test to Sidkiq 7+
@fallwith
Copy link
Contributor Author

Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.79% 93%
Branch 69.55% 50%

Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fallwith fallwith merged commit 41430b2 into dev Sep 3, 2024
141 checks passed
@fallwith fallwith deleted the sidekiq_inline branch September 3, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants