Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: don't use return in Redis detection #2816

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Bugfix: don't use return in Redis detection #2816

merged 2 commits into from
Aug 16, 2024

Conversation

fallwith
Copy link
Contributor

resolves #2814

@fallwith
Bugfix: don't use return in Redis detection
6719a92 
- Bugfix for #2814
- Added relevant regression test (with logic taking place in `Gemfile`
  before the instrumentation is loaded)

resolves #2814
@fallwith
CI: permit non 'gem' lines in Envfile
4326957 
use a new comment system to permit non 'gem' lines in `Envfile` files
@github-actions GitHub Actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.74% 93%
Branch 70.32% 50%

@fallwith fallwith merged commit b87231a into dev Aug 16, 2024
32 checks passed
@fallwith fallwith deleted the double_devon branch August 16, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@tannalynn tannalynn tannalynn approved these changes

@hannahramadan hannahramadan Awaiting requested review from hannahramadan hannahramadan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redis Cluster causes instrumentation error
3 participants
@fallwith @tannalynn @kaylareopelle