Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidekiq test: perms fix for inline bundled redis #2804

Closed
wants to merge 2 commits into from
Closed

sidekiq test: perms fix for inline bundled redis #2804

wants to merge 2 commits into from

Conversation

fallwith
Copy link
Contributor

We have observed CI errors related to Bundler refusing to clean up its inline bundled instance of redis. This fix seeks to proactively prevent the underlying permissions issue that causes the error.

We have observed CI errors related to Bundler refusing to clean up its
inline bundled instance of `redis`. This fix seeks to proactively
prevent the underlying permissions issue that causes the error.
tannalynn
tannalynn previously approved these changes Aug 12, 2024
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.88% 93%
Branch 70.69% 50%

kaylareopelle
kaylareopelle previously approved these changes Aug 12, 2024
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

fix a securerandom dependency issue now that Rails v7.2.0 has dropped
and ActiveSupport requires it
@fallwith fallwith dismissed stale reviews from kaylareopelle and tannalynn via 5f6e1b1 August 12, 2024 23:02
@fallwith fallwith closed this Aug 13, 2024
@fallwith fallwith deleted the sider branch August 13, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants