CI: test retry_stopped.active_job #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the ActiveJob notifications test suite by adding a test for the `retry_stopped.active_job` notification that Rails 6+ fires when it stops retrying to perform a job. resolves #1764
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
| @@ -6,11 +6,13 @@ | |||
| require 'new_relic/agent/instrumentation/active_job_subscriber' | |||
|
|
|||
| module NewRelic::Agent::Instrumentation | |||
| class RetryMe < StandardError; end | |||
There was a problem hiding this comment.
I like the alphabetization!
hannahramadan
approved these changes
Sep 22, 2023
tannalynn
approved these changes
Sep 22, 2023
fallwith
deleted the
take_a_break_you_must_be_tired_from_the_strain_take_a_break_and_let_us_carry_your_pain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the ActiveJob notifications test suite by adding a test for the
retry_stopped.active_jobnotification that Rails 6+ fires when it stops retrying to perform a job.resolves #1764