Update Elasticsearch port_path_or_id value #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `port_path_or_id` value for Elasticsearch segments
was set to the path given to the `request_with_tracing` method. This
caused a metrics grouping issue for a customer because a new
instance metric ("Datastore/instance/Elasticsearch/<host>/<port>")
was created for every Elasticsearch document ID.
The source of the host value is a hash that also contains a port key. This
commit updates the value of `port_path_or_id` to use the port from the
`nr_hosts` hash.
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
hannahramadan
previously approved these changes
Sep 1, 2023
fallwith
previously approved these changes
Sep 2, 2023
kaylareopelle
dismissed stale reviews from fallwith and hannahramadan
via
55a092a
kaylareopelle
commented
Sep 11, 2023
|
|
||
| - **Feature: Add Stripe instrumentation** | ||
|
|
There was a problem hiding this comment.
We normally have a newline between the heading and the description.
fallwith
approved these changes
Sep 11, 2023
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
port_path_or_idvalue for Elasticsearch segments was set to the path given to therequest_with_tracingmethod. This caused a metrics grouping issue for a customer because a new instance metric ("Datastore/instance/Elasticsearch//") was created for every Elasticsearch document ID.The source of the host value is a hash that also contains a port key. This commit updates the value of
port_path_or_idto use the port from thenr_hostshash.