Skip to content

Commit

Permalink
Remove deprecation messages for completed actions
Browse files Browse the repository at this point in the history
The versions mentioned in the deprecation messages have already been
removed from our testing matrix.
  • Loading branch information
kaylareopelle committed Aug 7, 2024
1 parent 7dae0d9 commit 858a9a5
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 75 deletions.
13 changes: 0 additions & 13 deletions lib/new_relic/agent/instrumentation/active_merchant.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,4 @@ class ActiveMerchant::Billing::Gateway
end
end
end

executes do
next unless Gem::Version.new(ActiveMerchant::VERSION) < Gem::Version.new('1.65.0')

deprecation_msg = 'The Ruby agent is dropping support for ActiveMerchant versions below 1.65.0 ' \
'in version 9.0.0. Please upgrade your ActiveMerchant version to continue receiving full support. ' \

NewRelic::Agent.logger.log_once(
:warn,
:deprecated_active_merchant_version,
deprecation_msg
)
end
end
19 changes: 0 additions & 19 deletions lib/new_relic/agent/instrumentation/delayed_job_instrumentation.rb
Original file line number Diff line number Diff line change
Expand Up @@ -93,23 +93,4 @@ def method_name(payload_object)
chain_instrument NewRelic::Agent::Instrumentation::DelayedJob::Chain
end
end

executes do
next unless delayed_job_version < Gem::Version.new('4.1.0')

deprecation_msg = 'Instrumentation for DelayedJob versions below 4.1.0 is deprecated.' \
'It will stop being monitored in version 9.0.0. ' \
'Please upgrade your DelayedJob version to continue receiving full support. ' \

NewRelic::Agent.logger.log_once(
:warn,
:deprecated_delayed_job_version,
deprecation_msg
)
end

def delayed_job_version
# the following line needs else branch coverage
Gem.loaded_specs['delayed_job'].version if Gem.loaded_specs['delayed_job'] # rubocop:disable Style/SafeNavigation
end
end
16 changes: 0 additions & 16 deletions lib/new_relic/agent/instrumentation/excon.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,6 @@
end
end

executes do
next unless Gem::Version.new(Excon::VERSION) < Gem::Version.new('0.56.0')

deprecation_msg = 'Instrumentation for Excon versions below 0.56.0 is deprecated.' \
'They will stop being monitored in version 9.0.0. ' \
'Please upgrade your Excon version to continue receiving full support. '

NewRelic::Agent.logger.log_once(
:warn,
:deprecated_excon_version,
deprecation_msg
)

NewRelic::Agent.record_metric('Supportability/Deprecated/Excon', 1)
end

def install_excon_instrumentation(excon_version)
require 'new_relic/agent/distributed_tracing/cross_app_tracing'
require 'new_relic/agent/http_clients/excon_wrappers'
Expand Down
14 changes: 0 additions & 14 deletions lib/new_relic/agent/instrumentation/sidekiq.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,18 +41,4 @@
end
end
end

executes do
next unless Gem::Version.new(Sidekiq::VERSION) < Gem::Version.new('5.0.0')

deprecation_msg = 'Instrumentation for Sidekiq versions below 5.0.0 is deprecated ' \
'and will be dropped entirely in a future major New Relic Ruby agent release.' \
'Please upgrade your Sidekiq version to continue receiving full support. '

NewRelic::Agent.logger.log_once(
:warn,
:deprecated_sidekiq_version,
deprecation_msg
)
end
end
13 changes: 0 additions & 13 deletions lib/new_relic/agent/instrumentation/sinatra.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,4 @@
chain_instrument NewRelic::Agent::Instrumentation::Sinatra::Build::Chain
end
end

executes do
next unless Gem::Version.new(Sinatra::VERSION) < Gem::Version.new('2.0.0')

deprecation_msg = 'The Ruby agent is dropping support for Sinatra versions below 2.0.0 ' \
'in version 9.0.0. Please upgrade your Sinatra version to continue receiving full compatibility. ' \

NewRelic::Agent.logger.log_once(
:warn,
:deprecated_sinatra_version,
deprecation_msg
)
end
end

0 comments on commit 858a9a5

Please sign in to comment.