Skip to content

Commit

Permalink
CI: stream test - only check for send_test_stream
Browse files Browse the repository at this point in the history
For this Rails v7.2+ test, only check for send_test_stream as the
official non-beta release of v7.2.0 and Rails v8.0.0.alpha both only
result in send_test_stream being reported
  • Loading branch information
fallwith committed Aug 12, 2024
1 parent b1d192f commit 195aaf7
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions test/multiverse/suites/rails/action_controller_other_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,11 @@ def test_send_data
end

def test_send_stream
# rails/rails@ed68af0 now defers all streaming behavior over to Rack (v3+) itself, so test
# only versions >= 7.2 and < 8.0
skip unless rails_version_at_least?('7.2') && !rails_version_at_least?('8.0.0.alpha')
skip unless rails_version_at_least?('7.2')

get('/data/send_test_stream')

assert_metrics_recorded(['Controller/data/send_test_stream', 'Ruby/ActionController/send_stream'])
assert_metrics_recorded(['Controller/data/send_test_stream'])
end

def test_halted_callback
Expand Down

0 comments on commit 195aaf7

Please sign in to comment.