Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Motor Instrumentation #1255

Merged
merged 14 commits into from
Nov 25, 2024
Merged

Add Motor Instrumentation #1255

merged 14 commits into from
Nov 25, 2024

Conversation

TimPansino
Copy link
Contributor

Overview

  • Add instrumentation and testing for Motor
    • Just like PyMongo, load balancing setups intentionally left without instance info to avoid reporting confusing and often incorrect information about query routing.

@TimPansino TimPansino requested a review from a team as a code owner November 19, 2024 19:20
Copy link

github-actions bot commented Nov 19, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 5.65s
✅ PYTHON black 5 0 0 2.01s
✅ PYTHON flake8 5 0 1.14s
✅ PYTHON isort 5 0 0 0.23s
✅ PYTHON pylint 5 0 7.26s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.28%. Comparing base (82a79b2) to head (15b400a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
+ Coverage   81.18%   81.28%   +0.10%     
==========================================
  Files         200      200              
  Lines       21971    21972       +1     
  Branches     3482     3482              
==========================================
+ Hits        17837    17861      +24     
+ Misses       2984     2963      -21     
+ Partials     1150     1148       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing as the other PR, I just want to make sure we aren't going to fail with an attr doesn't exist error.

newrelic/hooks/datastore_motor.py Outdated Show resolved Hide resolved
hmstepanek
hmstepanek previously approved these changes Nov 25, 2024
@mergify mergify bot removed the tests-failing label Nov 25, 2024
@TimPansino TimPansino merged commit def1ec7 into main Nov 25, 2024
56 checks passed
@TimPansino TimPansino deleted the feature-motor branch November 25, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants