-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Priority Sampling Error Events Test #1054
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
==========================================
- Coverage 81.15% 81.13% -0.03%
==========================================
Files 190 190
Lines 19747 19747
Branches 3468 3468
==========================================
- Hits 16025 16021 -4
- Misses 2732 2735 +3
- Partials 990 991 +1 ☔ View full report in Codecov by Sentry. |
5d96385
to
00ae8d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. Some of the tests are failing but they don't look to be related.
Nope, still fails, just with less frequency :( Closing this ticket. |
Overview
This PR makes the
test_priority_used_in_transaction_error_events
found intests/agent_features/test_priority_sampling.py
run more consistently. Here, the priority measured can be 1 or 2 depending on the randomness in sampling computation.