Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Priority Sampling Error Events Test #1054

Closed
wants to merge 12 commits into from

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Jan 31, 2024

Overview

This PR makes the test_priority_used_in_transaction_error_events found in tests/agent_features/test_priority_sampling.py run more consistently. Here, the priority measured can be 1 or 2 depending on the randomness in sampling computation.

Copy link

github-actions bot commented Jan 31, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 1 0 0 0.58s
✅ PYTHON flake8 1 0 0.36s
✅ PYTHON isort 1 0 0 0.17s
✅ PYTHON pylint 1 0 1.4s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fd639d) 81.15% compared to head (2ff6304) 81.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
- Coverage   81.15%   81.13%   -0.03%     
==========================================
  Files         190      190              
  Lines       19747    19747              
  Branches     3468     3468              
==========================================
- Hits        16025    16021       -4     
- Misses       2732     2735       +3     
- Partials      990      991       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrafeei lrafeei force-pushed the fix-flaky-priority-sampling-test branch from 5d96385 to 00ae8d3 Compare February 1, 2024 00:30
@mergify mergify bot removed the tests-failing label Feb 21, 2024
@lrafeei lrafeei marked this pull request as ready for review February 21, 2024 01:38
@lrafeei lrafeei requested a review from a team February 21, 2024 01:38
@mergify mergify bot removed the tests-failing label Feb 22, 2024
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Some of the tests are failing but they don't look to be related.

@lrafeei
Copy link
Contributor Author

lrafeei commented Mar 26, 2024

Nope, still fails, just with less frequency :(

Closing this ticket.

@lrafeei lrafeei closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants