Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USB-C ports #242

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add USB-C ports #242

wants to merge 2 commits into from

Conversation

Toxblh
Copy link

@Toxblh Toxblh commented Mar 11, 2023

Add USB-C ports
Source https://github.com/alin23/Lunar/blob/master/Lunar/DDC/DDC.swift
Checked on DELL U4021QW

@Toxblh
Copy link
Author

Toxblh commented Mar 11, 2023

Last spec 2.2a which updated at Jan 2011 for MCCS/VESA.
But all tested monitors following the ID's looks like it's standard de-facto

@newAM
Copy link
Owner

newAM commented Mar 11, 2023

Does that linked source file have the same values? There's no references to 0x19 or 0x20 for type-c monitors in there.

I want to make sure this is universal enough before adding it. In #170 / #171, and #93 the value is 27 (0x1B) for type c, and 33 (0x21) in #143. #93 is also a dell which implies this isn't even consistent for the same manufacturer...

@Toxblh
Copy link
Author

Toxblh commented Mar 11, 2023

So yes, I use the app in macos, lines with codes
https://github.com/alin23/Lunar/blob/master/Lunar/DDC/DDC.swift#L79
https://github.com/alin23/Lunar/blob/master/Lunar/DDC/DDC.swift#L80

Thank you for case regarding #143
Looks like MSI publish more values then need (maybe for internal usage with their soft)
But anyway 0x1B (27) and 0x19 (25) don't be overlap with 60(00 11 12 0F 21 22 2F 31) we can guess they following the standard de-facto.

Only the 2 codes above I saw in wild world.

@Toxblh
Copy link
Author

Toxblh commented Mar 11, 2023

Btw

and 33 (0x21) in #143

33 here is not usb-c. The monitor doesn't have the connection physically. Only 3 - DP and 2 HDMI (11 12 0F)

And why it's inconsistent? Like by 2 ports for hdmi and DP in standard
They can use usb1/usb2

My string
'(prot(monitor)type(lcd)model(U4021QW)cmds(01 02 03 07 0C E3 F3)vcp(02 04 05 08 10 12 14(01 04 05 06 08 09 0B 0C) 16 18 1A 52 60( 19 0F 11 12) 62 AC AE B2 B6 C6 C8 C9 CC(02 03 04 06 09 0A 0D 0E) D6(01 04 05) DC(00 03 05) DF E0 E1 E2(00 02 04 0C 0D 0F 10 11 13 0B 1B 14) E4 E5 E7(00 02) E8 E9(00 01 02 21 22 24 27 28 29 2A) F0(00 05 06 0A) F1 F2 FE FD)mccs_ver(2.1)mswhql(1))\x00'

60( 19 0F 11 12)

@Toxblh
Copy link
Author

Toxblh commented Mar 12, 2023

Mmm looked to DB https://github.com/ddccontrol/ddccontrol-db (try to search in repo usb-c as internal standard)
And https://github.com/7orlum/Viewsonic-VP2785-4K-MCCS/blob/master/docs/Viewsonic%20VP2785-4K%20MCCS%20codes.xlsx

Looks like I am based on Dell and LG, others can use diff.
Agree, that not fully correct, even if apply for most cases.

Stay that on your choose.

@newAM
Copy link
Owner

newAM commented Mar 13, 2023

That's a super useful resource that I didn't know existed, thanks!

I sent an email to VESA asking if there is any plan to update the MCCS for USB Type-C. Maybe I'll get a response that helps resolve this.

@Toxblh
Copy link
Author

Toxblh commented Jun 21, 2023

@newAM Hi, did you receive any answer for your email?

@newAM
Copy link
Owner

newAM commented Jun 21, 2023

Sadly not even an auto-generated reply :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants