Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Framework and initial tests #2

Merged
merged 22 commits into from
Nov 4, 2024
Merged

Testing Framework and initial tests #2

merged 22 commits into from
Nov 4, 2024

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Nov 1, 2024

It includes the testing framework, initial tests, ruff code D and docstrings, and some other improvements

Short description of the changes:

It includes:

  • pytest configurations and fixtures
  • initial tests for main window, application start, version, configuration settings
  • argument parsing
  • ruff code D added for dosctrings
  • docstrings in classes, tests and files added
  • init update for importing in Mantid workbench
  • HyspecPlanningTool class changes in _new_ ()

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

[Story][PPT] Include initial tests in the code base

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (1978169) to head (ecbc044).

Additional details and impacted files
@@            Coverage Diff             @@
##            next       #2       +/-   ##
==========================================
+ Coverage   1.60%   90.50%   +88.90%     
==========================================
  Files          4        8        +4     
  Lines        125      158       +33     
==========================================
+ Hits           2      143      +141     
+ Misses       123       15      -108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/unittest.yml Outdated Show resolved Hide resolved
@mpatrou mpatrou merged commit 4747d27 into next Nov 4, 2024
2 checks passed
@mpatrou mpatrou deleted the initial_test branch November 4, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants