Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Implement histogram binning #24

Closed
wants to merge 1 commit into from
Closed

[DRAFT] Implement histogram binning #24

wants to merge 1 commit into from

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Jun 17, 2022 •
edited
Loading

Co-Authored-By: p-teng 54685205+p-teng@users.noreply.github.com

Reference Issues/PRs

Fixes: #23

What does this implement/fix? Explain your changes.

Any other comments?

@PSSF23 @p-teng
Implement histogram binning
b194187 
Co-Authored-By: p-teng <54685205+p-teng@users.noreply.github.com>
adam2392
adam2392 commented Jun 17, 2022
View reviewed changes
Copy link
Collaborator Author

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PSSF23 do you know why we needed to copy the following files into ensemble/*?

  • sklearn/ensemble/_binning.py
  • sklearn/ensemble/_bitset.pxd
  • sklearn/ensemble/_bitset.pyx
  • sklearn/ensemble/utils.pyx

?

@adam2392 adam2392 mentioned this pull request Jun 17, 2022
Open
PSSF23
PSSF23 reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@PSSF23 PSSF23 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam2392 I don't really understand either. Feel free to edit it if needed.

@adam2392 adam2392 mentioned this pull request Jun 21, 2022
Closed
@adam2392 adam2392 closed this Jun 29, 2022
@adam2392 adam2392 deleted the hist branch March 8, 2023 20:37
@adam2392 adam2392 restored the hist branch March 8, 2023 20:37
@adam2392 adam2392 deleted the hist branch April 4, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSSF23 PSSF23 PSSF23 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] Adding binning capabilities to decision trees
2 participants
@adam2392 @PSSF23