-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1974: Refactor network events to return list of maps instead of strings #458
NETOBSERV-1974: Refactor network events to return list of maps instead of strings #458
Conversation
1898462
to
f1f8f9d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 29.56% 29.65% +0.08%
==========================================
Files 50 50
Lines 4867 4863 -4
==========================================
+ Hits 1439 1442 +3
+ Misses 3322 3316 -6
+ Partials 106 105 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f1f8f9d
to
dadc2d4
Compare
dadc2d4
to
3c9c003
Compare
3c9c003
to
4508e61
Compare
4508e61
to
c802238
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=2f889b8 make set-agent-image |
c802238
to
2b70933
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=18481c0 make set-agent-image |
2b70933
to
f39deb8
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=2c10edc make set-agent-image |
f39deb8
to
dbc88d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e922690
to
516bcd8
Compare
516bcd8
to
49dfd1c
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=d92e038 make set-agent-image |
/lgtm |
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
49dfd1c
to
8a66665
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=d61148e make set-agent-image |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@msherif1234: This pull request references NETOBSERV-1974 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Description
Network events was orignally decode as string with this recent ovnk lib it will come as struct and the agent need to generate list of configmaps with those events
this effort to allow generating metrics with network events
Dependencies
ovn-kubernetes/ovn-kubernetes#4818
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.