Feat: Allow to set filename for template (FIXED) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add default filename when the given param is empty; - Adjusts the tests\Component\DocumentTest.php to expect the filename param; - Adjusts the tests\WhatsAppTemplateTest.php to expect the filename param;
aalbarca
reviewed
Mar 10, 2024
|
Hi @spectrewall this PR is blocked due an unsuccesful pipeline: https://github.styleci.io/analyses/yrmB3o?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link You can fix this error running php cs fixer or fix manually the style issues. |
|
Hi @aalbarca, Sorry for being late on this, but a just fixed the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added filename parameter to allow developers to set filename in template message.
Work based on PR: #8 but as it seens to be forgotten, i took the liberty to add what was asked.