Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fixed documentation indentation mistake #251

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

Codixer
Copy link
Contributor

@Codixer Codixer commented Nov 20, 2024

Someone made a mistake when editing the docs, thinking they added a comment. Fixed this as it looks weird on the actual ui.

Someone made a mistake when editing the docs, thinking they added a comment. Fixed this as it looks weird on the actual ui.
@Codixer
Copy link
Contributor Author

Codixer commented Nov 20, 2024

Additionally, the person was actually right. Fixed that issue in the meantime as well.

@Codixer
Copy link
Contributor Author

Codixer commented Nov 20, 2024

While 29a528f is technicly correct. It's if you install the plugin instead of the command line method
(curl -sSL https://get.docker.com/ | CHANNEL=stable bash)

Most people might have already installed docker directly instead of the docker plugin, so that command would rather apply then the plugin command.

Docker cannot detect the container if it's not using the compose file. Hence re-adding the compose for the copy command.
mlsmaycon
mlsmaycon previously approved these changes Nov 22, 2024
# Conflicts:
#	src/pages/selfhosted/selfhosted-guide.mdx
@mlsmaycon mlsmaycon merged commit f74b56c into netbirdio:main Nov 22, 2024
1 check passed
@mlsmaycon
Copy link
Contributor

mlsmaycon commented Nov 22, 2024

thanks @Codixer. The plugin should be fine since is easier to install than the old composer, so we expect most users to migrate to it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants