Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log booster_config with float parameters #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Log booster_config with float parameters #9

wants to merge 1 commit into from

Conversation

shnela
Copy link
Contributor

@shnela shnela commented Nov 9, 2021

No description provided.

Raalsky
Raalsky reviewed Nov 9, 2021
View reviewed changes
neptune_xgboost/impl/__init__.py
self.run["booster_config"] = json.loads(model.save_config())
booster_config_with_floats = json.loads(
model.save_config(),
object_pairs_hook=lambda e: {k: self._as_float(v) for k, v in e}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Made _as_float to accept a tuple (if we would like in future to handle some specific attributes).
  2. Rename it to _convert_model_config
  3. Call via class instead of self as it's misleading to be a instance method

@twolodzko
Copy link

@shnela @Raalsky is this relevant? I don't know the context, so it's hard to judge.

@twolodzko
Copy link

Is this still relevant @shnela @Raalsky ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raalsky Raalsky Raalsky left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shnela @twolodzko @Raalsky