Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency overrides #214

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Conversation

Matyrobbrt
Copy link
Member

@Matyrobbrt Matyrobbrt commented Nov 14, 2024

This implements a simple system that allows users to override dependency constraints using the fml config by adding an entry as follows:

dependencyOverrides.target = ["-dep1", "+dep2"]

Minus can be used to soften dependency constraints (version range becomes unbounded, type becomes optional, but the ordering stays the same) and plus can be used to add an ordering dependency (the target mod will load AFTER the dependency)
All overrides are marked in the log at WARN level for visibility.
Closes #52

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 14, 2024

  • Publish PR to GitHub Packages

Last commit published: 079682bd84a6148039eafc0ea7326a755b7145a8.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #214' // https://github.com/neoforged/FancyModLoader/pull/214
        url 'https://prmaven.neoforged.net/FancyModLoader/pr214'
        content {
            includeModule('net.neoforged.fancymodloader', 'tests')
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
        }
    }
}

@TelepathicGrunt
Copy link
Contributor

“dependencyOverries”
Typo in description btw. Just double check typo isn’t in the code too.

@Matyrobbrt Matyrobbrt added the enhancement New feature or request label Nov 15, 2024
@shartte
Copy link
Contributor

shartte commented Nov 15, 2024

Simple and you even added tests! <3

@neoforged-automation neoforged-automation bot added the needs rebase This Pull Request needs to be rebased before being merged label Nov 25, 2024
@neoforged-automation
Copy link

@Matyrobbrt, this pull request has conflicts, please resolve them for this PR to move forward.

@neoforged-automation neoforged-automation bot removed the needs rebase This Pull Request needs to be rebased before being merged label Nov 25, 2024
@Matyrobbrt Matyrobbrt requested review from Technici4n and removed request for Technici4n November 25, 2024 14:36
@Technici4n Technici4n merged commit 7e025c2 into neoforged:main Nov 25, 2024
3 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as FancyModLoader version 5.0.6.

@Matyrobbrt Matyrobbrt deleted the dep-overrides branch November 25, 2024 21:44
Matyrobbrt added a commit to Matyrobbrt/FancyModLoader that referenced this pull request Nov 25, 2024
Technici4n pushed a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dependency override for player/pack maker to bypass limits set in mod's mods.toml file
4 participants