feat: add methods to provide additional/finer config params #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meistermeier
changed the title
ali-ince
changed the title
ali-ince
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Looks good to me. I think we are only missing a couple of small things;
- We need to pass in the new selector fields
authenticatedUser,executingUserandtxMetadatato the procedure, by updating theEntitySelector#asMapaccording to https://neo4j.com/docs/cdc/current/selectors/#_metadata_selectors. - Would be nice to verify if we are able to filter changes by the newly added metadata selectors.
- Would be nice to see if
Metadata.txMetadatafield is being populated by writing an IT.
Happy to do those if you are out of time.
ali-ince
force-pushed
the
kafka-cdc-config
branch
from
5f4b377
to
31c85c0
Compare
ali-ince
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used by the kafka-connector