Refactoring createContainer #515
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many "createContainer" methods which are very similar.
Are they different by thoughtful design or it just happened?
Would there be a benefit by refactoring them to one?
To what extent is Is it possible to to reuse running containers in order to speed up testing?
As most tests modify environment variables before starting the container its seems not possible to a great extent
but in TestBasic the same container is now used 5 times, which would be an decrease in test-time by ca 2 minutes in the pipeline. (Startup time of a container is usually 25-30 sec)